Skip to content

GH-139193: Fix dump_stack when PYTHON_LLTRACE=4 #139384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

GH-139193: Fix dump_stack when PYTHON_LLTRACE=4 #139384

wants to merge 4 commits into from

Conversation

sergey-miryanov
Copy link
Contributor

@sergey-miryanov sergey-miryanov commented Sep 27, 2025 •
edited
Loading

There are two problems:

  1. dump_stack/dump_item should ignore items that pushed on the stack with PyStackRef_Wrap
  2. PyStackRef_IsError should test only Py_TAG_BITS of .bits not whole .bits value

Also, PyStackRef_IsValid should be fixed accordingly.

@bedevere-app bedevere-app bot mentioned this pull request Sep 27, 2025
Open
@sergey-miryanov
Copy link
Contributor Author

PR ready to review, please take a look.

Fidget-Spinner
Fidget-Spinner approved these changes Sep 27, 2025
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sergey-miryanov
Copy link
Contributor Author

@Fidget-Spinner Thanks for review! I tried to fix PyStackRef_IsValid accordingly, because I oversight it yesterday.

@sergey-miryanov
Copy link
Contributor Author

I revert it because it was not right.

@markshannon
Copy link
Member

PyStackRef_IsError should return true only for PyStackRef_ERROR

@markshannon
Copy link
Member

Any suggestions for a better name are welcome, as it is obviously not clear.

@sergey-miryanov
Copy link
Contributor Author

@markshannon What do you think about adding new function PyStackRef_IsInvalid to check is INVALID bit is set or no? And fix PyStackRef_IsError to check as you said above?

@markshannon
Copy link
Member

@markshannon What do you think about adding new function PyStackRef_IsInvalid to check is INVALID bit is set or no? And fix PyStackRef_IsError to check as you said above?

That sounds good. Leave PyStackRef_IsError untouched and add PyStackRef_IsMalformed.
It is tricky choosing a name that indicates that the stackef is broken, not that the ref is correct but thing it refers to is broken.
I think "malformed" conveys that a bit better than "invalid", but feel free to pick the name you think is clearest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergey-miryanov @markshannon @Fidget-Spinner